Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/stage command #394

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
45e184e
Add tests for pear stage
jkcdarunday Aug 5, 2024
79ebd94
Enable commands test
jkcdarunday Aug 5, 2024
ab2f07d
Make names more consistent
jkcdarunday Aug 5, 2024
b67db6a
Fix comment after test ends error
jkcdarunday Aug 5, 2024
fd2e334
Comment out tests that use --name
jkcdarunday Aug 6, 2024
eb87277
Fix SIGPIPE error by switching to ipc destroy
jkcdarunday Aug 6, 2024
e48630e
Fix wrong package.json being used
jkcdarunday Aug 6, 2024
1bf012b
Add ignoring of unparseable JSON
jkcdarunday Aug 6, 2024
92771ae
Revert "Add ignoring of unparseable JSON"
jkcdarunday Aug 7, 2024
109f9d9
Update tests that edit package.json to use temp dir
jkcdarunday Aug 20, 2024
8088482
Uncomment --name tests
jkcdarunday Aug 22, 2024
3c8c111
Use tmp platform to run test commands
jkcdarunday Aug 26, 2024
85ca8c4
Use localdev to run command tests
jkcdarunday Aug 28, 2024
a031cbb
Use localdev for all command test runners
jkcdarunday Aug 28, 2024
5bd257e
Remove platformDir since we now have tests running with staged localdev
jkcdarunday Sep 11, 2024
c18b1f2
Remove exit code checks due until Windows exit code bug is fixed
jkcdarunday Sep 12, 2024
f6fcdae
Add TODO for readding exit code checks
jkcdarunday Sep 12, 2024
0bc1a87
Remove exit code checks for initial stage
jkcdarunday Sep 12, 2024
1c480ee
Revert "Remove exit code checks for initial stage"
jkcdarunday Sep 13, 2024
7fc2cb1
Revert "Add TODO for readding exit code checks"
jkcdarunday Sep 13, 2024
f48b3f2
Revert "Remove exit code checks due until Windows exit code bug is fi…
jkcdarunday Sep 13, 2024
ff726f2
Rename close to _close in harness to prevent overriding
jkcdarunday Sep 13, 2024
71565e2
Use sync fs during brittle teardown
jkcdarunday Sep 13, 2024
fad6ab4
Rename commands test prefix from 05 to 07
jkcdarunday Sep 19, 2024
22ea5c7
Use Helper.localDir instead of Helper.root
jkcdarunday Sep 19, 2024
bb48752
Switch helper back to use pearDir
jkcdarunday Sep 20, 2024
5adc2bf
Revert "Switch helper back to use pearDir"
jkcdarunday Sep 23, 2024
0050d82
Override platformDir when instantiating Helper from harness
jkcdarunday Sep 23, 2024
32b547e
Cleanup todos
jkcdarunday Sep 25, 2024
ce8d175
Disable helper teardown when loaded from harness
jkcdarunday Oct 7, 2024
47bf4bc
Add closing of the helper and use close instead of IPC destroy
jkcdarunday Oct 8, 2024
c842a4f
Remove rig
jkcdarunday Oct 9, 2024
b462adb
Remove newlines in evaluate calls
jkcdarunday Oct 9, 2024
b38eca1
Add missing tags check
jkcdarunday Oct 10, 2024
b693b58
Use Helper static field to signal if teardown should be skipped
jkcdarunday Oct 10, 2024
3e90fcb
Remove skipping of teardown
jkcdarunday Oct 10, 2024
9247d19
Use staged rig for all tests
jkcdarunday Oct 10, 2024
e6d9465
A logging of actual exit code
jkcdarunday Oct 10, 2024
f763bcf
Disable unused rig keepalive connection
jkcdarunday Oct 10, 2024
d5bbacb
Temporarily disable non-failing tests
jkcdarunday Oct 10, 2024
4424ebd
Fix harness teardown using a non-existent runtime
jkcdarunday Oct 10, 2024
628e494
Add missing this
jkcdarunday Oct 10, 2024
7ed5f00
Revert "Temporarily disable non-failing tests"
jkcdarunday Oct 21, 2024
0064f10
Add ensuring that rig has been shut down
jkcdarunday Oct 22, 2024
5765ad3
Use mirror.done instead of awaiting mirror output
jkcdarunday Oct 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/06-shutdown.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@ test('sidecar should not spindown until ongoing update is finished', async (t) =

t.comment('\tStaging patched platform')
const rigHelper = new Helper(rig)
t.teardown(() => rigHelper.close(), { order: Infinity })
t.teardown(async () => {
if (!rigHelper.closing) {
await rigHelper.shutdown()
await rigHelper.close()
}
}, { order: Infinity })
await rigHelper.ready()

const patchedStager = rigHelper.stage({ channel: 'test-spindown-throttled', name: 'test-spindown-throttled', dir: patchedArtefactDir, dryRun: false, bare: true })
Expand All @@ -166,6 +171,7 @@ test('sidecar should not spindown until ongoing update is finished', async (t) =
t.teardown(() => Helper.gc(platformDirRcv))

await Helper.teardownStream(patchedSeeder)
await rigHelper.shutdown()
await rigHelper.close()

t.comment('2. Start patched rcv platform')
Expand Down
Loading
Loading