-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure worker close gracefully with the same behaviours in both Terminal and Desktop apps #459
Open
maidh91
wants to merge
26
commits into
main
Choose a base branch
from
improve-worker-close
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidh91
changed the title
ensure worker destroy gracefully
ensure worker close gracefully
Nov 22, 2024
maidh91
requested review from
davidmarkclements,
rafapaezbas and
jkcdarunday
November 22, 2024 10:56
maidh91
changed the title
ensure worker close gracefully
Ensure worker close gracefully
Nov 22, 2024
maidh91
changed the title
Ensure worker close gracefully
Ensure worker close gracefully with the same behaviours in both Terminal and Desktop apps
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Type
Pear.Worker.run
api to start Worker processpipe.end
orpipe.destroy
Scenarios
Parent calls
pipe.end()
end
eventclose
eventend
eventclose
eventParent calls
pipe.destroy()
end
eventclose
eventclose
event only (noend
event)Worker calls
pipe.end()
end
eventclose
eventend
eventclose
eventWorker calls
pipe.end()
close
event only (noend
event)end
eventclose
eventHow to test
Sample Parent code
Sample Worker code
pear.dev run -d parent-code-dir
/tmp/test-data
,/tmp/test-end
,/tmp/test-close
for worker events