Add Android support to preinstall.js #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this change I'm able to compile sodium-native (3.0.0) from source on my device (ARM64 on Android 10)! |
Problem: When compiling from source on Android, the process exits with code 1 without printing an error. Solution: Add console output in case of an error, which may be useful for debugging, and treat the Android platform the same way that we're currently treating OpenBSD, FreeBSD, and Linux.
christianbundy
force-pushed
the
android
branch
from
21563f6 to
45d75e1
Compare
christianbundy
commented
Feb 22, 2020
| @@ -35,7 +36,7 @@ if (process.argv.indexOf('--print-lib') > -1) { | |||
| console.log('../libsodium/Build/ReleaseDLL/' + warch + '/libsodium.lib') | |||
| break | |||
| default: | |||
| process.exit(1) | |||
| throw new Error('Unsupported platform: ' + os.platform()) | |||
There was a problem hiding this comment.
We have two other options here:
console.log()
console.log('Unsupported platform: ' + os.platform())
process.exit(1)No output
I was confused when the process exited without any output, but maybe there's a good reason to do it that way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When compiling from source on Android, the process exits with
code 1 without printing an error.
Solution: Add console output in case of an error, which may be useful
for debugging, and treat the Android platform the same way that we're
currently treating OpenBSD, FreeBSD, and Linux.
See also: https://github.com/sodium-friends/sodium-native/issues/119#issuecomment-590003696