Remove :au_tas test for the time being #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @ghiculescu and @adamlyons2. Unfortunately I have more bad news here. What I've discovered is that everything is working as intended, except...for this in the ruby repo: https://github.com/holidays/holidays/blob/master/lib/holidays/finder/rules/in_region.rb#L9-L21
Basically, when we determine whether a specific date is 'in a region' we also currently check its parent region. By adding back in
:au
we are telling:au_tas
to also grab any:au
holidays, which means it ALSO picks up the NYD from 1/1. This isn't what you wanted but...I don't see an easy fix for the moment.The problem is that there are a lot of other tests/features that rely on this functionality. But you want to be able to say
:au_tas
and have it NOT pick up any:au
holidays. I think this is a new feature (which is totally fine) but I was hoping you could provide some feedback. What if we added a new flag to the ruby gem to 'ignore parent regions' if specified? For example, you could call:And it would only pull back exact matches for the region specified, not doing any expansion.
I don't know if
:exact
is a good name or what. But I think it makes sense that 'sub regions' pick up their parents by default...that makes the most sense to me. So adding in a flag to disable that might be the best option.I know I'm going back and forth on this and I apologize. Last three months have been a blur and I haven't really done you right on this front. 😦
Thoughts? I'm gonna merge this in so I can get green builds on the ruby side (since it's been so long) but we can definitely talk about it in the coming days.