Fix the benchmark tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Mar 23, 2020
holiman
pushed a commit
that referenced
this pull request
Mar 23, 2020
* Base algorithm * Pass the initial tests * Works with all available tests * Fix missing headers * Various fixes after rebase * Fix issue coming out of goerli sync * Code cleanup and documentation * More comments * Remove outdated tests * Compare StdGenerate with ReStackTrie * Fix the benchmark tests (#11)
holiman
pushed a commit
that referenced
this pull request
Nov 14, 2022
core: set withdrawals hash in genesis, fix tests, add withdrawalRoot
holiman
pushed a commit
that referenced
this pull request
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 4K benchmarks were hardcoding the root hash value and it was the wrong value.
The 10K benchmarks weren't testing the value.
This PR runs
StdGenerateonce to get the proper value. The issue with this approach is that it warms the cache and make it look a tiny bit (100μs on average) faster than it is without the cache.It also checks the output of 10K.
Finally, it replaces
StackGeneratewithReStackGenerate.