core, ethdb: use freezer batch for sync #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
May 25, 2021
core/blockchain.go
Outdated
Comment on lines
1225
to
1230
| if aBatch.ValueSize() > ethdb.IdealAncientBatchSize { | ||
| if err := aBatch.Write(); err != nil { | ||
| return i, err | ||
| } | ||
| aBatch.Reset() | ||
| } |
There was a problem hiding this comment.
It would be really nice if we can somehow avoid having the situation where e.g. the size of the receipts trigger flushes every second 'block', which flushes even the tiny things like td. If we can allow some portions to temporarily on-disk stray ahead of other parts, then we save a lot of syscalls.
That's what we were discussing yesterday on discord.
There was a problem hiding this comment.
It's a nice idea. I have to think about how to change the code.
holiman
reviewed
May 25, 2021
holiman
pushed a commit
that referenced
this pull request
Oct 6, 2021
eth: disable legacy syncing on the merge interop pr for now
holiman
pushed a commit
that referenced
this pull request
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.