core/state/snapshot, cmd/geth: polish code #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Jun 2, 2022
Comment on lines
+87
to
+90
| if !errors.Is(err, errNoJournal) { | ||
| log.Info("Failed to resolve snapshot journal", "err", err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
This can't be right. But changing it to if errors.Is won't make it correct either, I'm not quite sure why the distinction between errors is needed here?
There was a problem hiding this comment.
About this -- is there any reason to not just do
diff --git a/core/state/snapshot/utils.go b/core/state/snapshot/utils.go
index 505ad15a99..b88ea05484 100644
--- a/core/state/snapshot/utils.go
+++ b/core/state/snapshot/utils.go
@@ -84,7 +84,7 @@ func checkDanglingMemStorage(db ethdb.KeyValueStore) error {
}
return nil
})
- if !errors.Is(err, errNoJournal) {
+ if err != nil {
log.Info("Failed to resolve snapshot journal", "err", err)
return err
}
holiman
added a commit
that referenced
this pull request
Jun 7, 2022
…unt-check (ethereum#24765) * cmd/geth, core/state/snapshot: rework journal loading, implement account-check * core/state/snapshot, cmd/geth: polish code (#37) * core/state/snapshot: minor nits * core/state/snapshot: simplify error logic * cmd/geth: go format Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
holiman
pushed a commit
that referenced
this pull request
Nov 26, 2022
holiman
pushed a commit
that referenced
this pull request
Jul 7, 2023
* Add breadcrumbs to docs * change BreadcrumbLink to NextLink * Update src/components/docs/Breadcrumbs.tsx Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> * Update src/components/docs/Breadcrumbs.tsx Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.