Display useful upload errors

holium · Oct 2, 2023 · 66ba57d · 66ba57d
1 parent 4194e39
commit 66ba57d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/hosting-holium-com/src/pages/upload-pier.tsx b/hosting-holium-com/src/pages/upload-pier.tsx
@@ -1,6 +1,10 @@
 import { useEffect, useState } from 'react';
 
-import { OnboardingStorage, UploadPierDialog } from '@holium/shared';
+import {
+  OnboardingStorage,
+  uploadErrors,
+  UploadPierDialog,
+} from '@holium/shared';
 
 import { Page } from '../components/Page';
 import { thirdEarthApi } from '../util/thirdEarthApi';
@@ -68,7 +72,18 @@ export default function UploadPierPage() {
     const ship = await getUnbootedByopShip();
     if (!ship) return false;
 
-    return ship.ship_type.includes('pierReceived');
+    // If ship_type includes any of the keys in uploadErrors,
+    // then the upload failed, and we should show the error.
+    const shipType = ship.ship_type;
+    const defaultAdvice = 'Please refresh this page and try again.';
+
+    if (Object.keys(uploadErrors).includes(shipType)) {
+      setError(`${uploadErrors[shipType]} ${defaultAdvice}`);
+    } else if (shipType === 'hardError') {
+      setError(`Something went wrong with your upload. ${defaultAdvice}`);
+    }
+
+    return shipType.includes('pierReceived');
   };
 
   const prepareSftpServer = async () => {

diff --git a/shared/src/onboarding/dialogs/AccountUnfinishedUpload/AccountUnfinishedUploadDialogBody.tsx b/shared/src/onboarding/dialogs/AccountUnfinishedUpload/AccountUnfinishedUploadDialogBody.tsx
@@ -6,7 +6,7 @@ import { GrayButton } from '../../components/ChangeButton';
 import { OnboardDialogDescription } from '../../onboarding';
 
 // These errors are stored as the ship_type of the associated ship row in the database.
-const uploadErrors: Record<string, string> = {
+export const uploadErrors: Record<string, string> = {
   invalidFileError:
     'The uploaded .tar.gz or .zip file failed to be decompressed.',
   invalidFileFormatError:

diff --git a/shared/src/onboarding/onboarding.ts b/shared/src/onboarding/onboarding.ts
@@ -30,6 +30,7 @@ export {
   SUPPORT_EMAIL_ADDRESS,
 } from './dialogs/AccountSupport/helpers';
 export { AccountUnfinishedUploadDialog } from './dialogs/AccountUnfinishedUpload/AccountUnfinishedUploadDialog';
+export { uploadErrors } from './dialogs/AccountUnfinishedUpload/AccountUnfinishedUploadDialogBody';
 export { AddIdentityDialog } from './dialogs/AddIdentity/AddIdentityDialog';
 export { BootingDialog } from './dialogs/Booting/BootingDialog';
 export { ChooseIdentityDialog } from './dialogs/ChooseIdentity/ChooseIdentityDialog';