Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docked app status indicator and more #1031

Merged
merged 19 commits into from
Feb 12, 2023
Merged

Fix docked app status indicator and more #1031

merged 19 commits into from
Feb 12, 2023

Conversation

gdbroman
Copy link
Contributor

@gdbroman gdbroman commented Feb 10, 2023 •
edited
Loading

Bug fixes:

  • Fix bug where docked apps' status indicator (for isOpen/isActive) isn't consistently working
  • Fix bug where Pinned apps keep disappearing #988 by persisting the order in MobX
  • Fix bug where Relic browser window doesn't rise to top on focus

New stuff:

  • Add a hide/show context menu option
  • Opening an app should close the home pane
appdock_states.mov

@gdbroman gdbroman self-assigned this Feb 10, 2023
@gdbroman gdbroman added the enhancement New feature or request label Feb 10, 2023
@gdbroman gdbroman linked an issue Feb 10, 2023 that may be closed by this pull request
Pinned apps keep disappearing #988
Open
@gdbroman gdbroman force-pushed the 988-pinned-apps-keep-disappearing branch 3 times, most recently from dba8925 to 0c275cc Compare February 11, 2023 09:11
@gdbroman gdbroman changed the title Clean up AppDock animations + code Clean up pinned app states Feb 11, 2023
@gdbroman gdbroman added bug Something isn't working and removed bug Something isn't working labels Feb 11, 2023
@gdbroman gdbroman changed the title Clean up pinned app states Fix pinned app states Feb 11, 2023
@gdbroman gdbroman changed the title Fix pinned app states Fix DockApp states Feb 11, 2023
@gdbroman gdbroman force-pushed the 988-pinned-apps-keep-disappearing branch from 0c275cc to d8e59cf Compare February 11, 2023 09:25
@gdbroman gdbroman changed the title Fix DockApp states Fix AppDock states Feb 11, 2023
@gdbroman gdbroman force-pushed the 988-pinned-apps-keep-disappearing branch from fdbd07a to 6aaf6fc Compare February 12, 2023 10:24
@gdbroman gdbroman force-pushed the 988-pinned-apps-keep-disappearing branch from 198a0fd to 7ac6dea Compare February 12, 2023 11:03
@gdbroman gdbroman marked this pull request as ready for review February 12, 2023 11:23
@gdbroman gdbroman requested a review from drunkplato February 12, 2023 11:23
@gdbroman gdbroman added the bug Something isn't working label Feb 12, 2023
@gdbroman gdbroman changed the title Fix AppDock states Fix docked app status indicator and more Feb 12, 2023
@gdbroman gdbroman merged commit 2587080 into master Feb 12, 2023
@gdbroman gdbroman deleted the 988-pinned-apps-keep-disappearing branch February 12, 2023 16:50
@drunkplato drunkplato mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drunkplato drunkplato drunkplato approved these changes

Assignees

@gdbroman gdbroman

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pinned apps keep disappearing
2 participants
@gdbroman @drunkplato