Connection status integration #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-connection-10-minutes-and-triggers-boot-event
…e-connection-10-minutes-and-triggers-boot-event
…flow calls in the mocel need a .catch handler or will crash the UI
…e-connection-10-minutes-and-triggers-boot-event
…s along with a nullable cookie property in session.lock are used to force the app to grab a fresh cookie before attempting next operation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
…. added ConnectionStatus component to stand alone chat, added support for loss of internet, added reconnect support (manual on SSE error)
drunkplato
reviewed
Jun 20, 2023
| @@ -76,7 +76,7 @@ export class RealmService extends AbstractService<RealmUpdateTypes> { | |||
| ? { | |||
| serverId: session.patp, | |||
| serverUrl: session.url, | |||
| cookie: session.cookie, | |||
| cookie: session.cookie || '', | |||
| } | |||
drunkplato
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
upgrades the credentials table and session.lock file to accept null cookie values. this signals to the app that a new cookie should be fetched. one use case being when an SSE error event occurs.
Send Report button on the ConnectionStatus component is not plugged in
Supports reconnect after loss / reconnect of internet
SSE error conditions show the ConnectionStatus component. Clicking Reconnect button should reestablish clean connection.
Was getting 'quit' events in latest round of testing (tinkering with clog settings in eyre), and the app seems to handle these use cases successfully.