Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popout Chat bug fixes #1813

Merged
merged 8 commits into from
Jun 21, 2023
Merged

Popout Chat bug fixes #1813

merged 8 commits into from
Jun 21, 2023

Conversation

gdbroman
Copy link
Contributor

@gdbroman gdbroman commented Jun 19, 2023 •
edited
Loading

Ticket: RE-265

Description

Bugs fixed:

  • Delete msg doesn’t update the log when it’s not the last msg
  • Reply sometimes crashes the chat
  • New "Loading new messages" inbox header
  • Link clicking opens in webview window – should be native OS browser
  • ChatInbox list should resort on new messages (sent & received)
  • Video embed hides the cursor
  • Video upload sometimes doesn't work
  • Video refetches when scrolled back into view

Reviewer Checklist

  • Pipeline passes
  • Docs have been added / updated
  • Tests have been added / updated
  • Has been refactored if necessary

@gdbroman gdbroman self-assigned this Jun 19, 2023
@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
holium-com ⬜️ Ignored (Inspect) Jun 21, 2023 3:52pm
hosting-holium-com ⬜️ Ignored (Inspect) Jun 21, 2023 3:52pm
join-holium-com ⬜️ Ignored (Inspect) Jun 21, 2023 3:52pm

@gdbroman gdbroman added the bug Something isn't working label Jun 19, 2023
@gdbroman gdbroman force-pushed the RE-265-popout-chat-bugs branch 2 times, most recently from abb90aa to e15311c Compare June 20, 2023 19:27
@gdbroman
Copy link
Contributor Author

Video refetches when scrolled back into view

Keeping certain rows mounted outside the virtualization window is something Virtuoso is not planning on implementing. However, the video resource network request remains cached, so even though it unmounts, replaying it is instant. (Are you sure you didn't have "Disable cache" toggled in dev tools @drunkplato?). Theoretically, you could store a "resume" timestamp mapped to a unique video idea locally, but it does not seem worth the complexity cost to me, and something not even Twitter seems to be doing.

@gdbroman
Copy link
Contributor Author

gdbroman commented Jun 20, 2023 •
edited
Loading

Video upload sometimes doesn't work

I'm able to upload 30MB videos, makes me think perhaps you had a bucket-side issue @drunkplato

@gdbroman gdbroman force-pushed the RE-265-popout-chat-bugs branch 3 times, most recently from 88e7233 to a28b143 Compare June 21, 2023 15:47
@gdbroman gdbroman force-pushed the RE-265-popout-chat-bugs branch from a28b143 to a1e4bc7 Compare June 21, 2023 15:51
@gdbroman gdbroman marked this pull request as ready for review June 21, 2023 15:51
@gdbroman
Copy link
Contributor Author

ChatInbox list should resort on new messages (sent & received)

Breaking this one out as I might not have time to fix it before my flight and want to get the other fixes in.

@gdbroman gdbroman requested a review from drunkplato June 21, 2023 15:54
@gdbroman gdbroman merged commit a1de095 into master Jun 21, 2023
@gdbroman gdbroman deleted the RE-265-popout-chat-bugs branch June 21, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drunkplato drunkplato Awaiting requested review from drunkplato

Assignees

@gdbroman gdbroman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gdbroman