-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RE-219 SpaceBlock for /spaces/~zod/our type chat messages using custom type #1814
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tenari is attempting to deploy a commit to the Holium Team on Vercel. To accomplish this, @Tenari needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
Finally got it working. There was a compile error in the design system which made the design system not update. Fixed that and tweaked some styling. |
Ticket: RE-219
SpaceBlock in chat
uses red hint message "you are already in this space" if you are already in the space. otherwise, will fail using the same system as if a person tried to enter a space-path in the spaces tray app and it was wrong/unavailable
as far as
/spaces/
prefixin goes, I took the route of "it's a user-facing change" only. I didn't update any hoon agents to use that new format. I just updated the displays to show/spaces/
in front of the existing space paths, and to remove it when sending join/leave pokes to the ship