Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE-219 SpaceBlock for /spaces/~zod/our type chat messages using custom type #1814

Merged
merged 6 commits into from
Jun 30, 2023

Conversation

Tenari
Copy link
Contributor

@Tenari Tenari commented Jun 20, 2023

Ticket: RE-219

SpaceBlock in chat

uses red hint message "you are already in this space" if you are already in the space. otherwise, will fail using the same system as if a person tried to enter a space-path in the spaces tray app and it was wrong/unavailable

as far as /spaces/ prefixin goes, I took the route of "it's a user-facing change" only. I didn't update any hoon agents to use that new format. I just updated the displays to show /spaces/ in front of the existing space paths, and to remove it when sending join/leave pokes to the ship

@Tenari Tenari requested a review from drunkplato June 20, 2023 18:08
@holium holium deleted a comment from vercel bot Jun 21, 2023
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
join-holium-com-1734078674680-OIgO 🛑 Canceled (Inspect) Dec 13, 2024 8:31am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
holium-com ⬜️ Ignored (Inspect) Dec 13, 2024 8:31am
hosting-holium-com ⬜️ Ignored (Inspect) Dec 13, 2024 8:31am
join-holium-com ⬜️ Ignored (Inspect) Dec 13, 2024 8:31am

@holium holium deleted a comment from vercel bot Jun 26, 2023
@Tenari Tenari requested a review from drunkplato June 26, 2023 21:37
Copy link
Contributor

@drunkplato drunkplato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled changes and updated a local moon with the agent code but couldnt get the SpaceBlock to render

image

@holium holium deleted a comment from vercel bot Jun 28, 2023
@Tenari
Copy link
Contributor Author

Tenari commented Jun 28, 2023

can you try again with the format /spaces/~zod/one ?
image

@drunkplato
Copy link
Contributor

can you try again with the format /spaces/~zod/one ? image

I tried this format /spaces/~lomder-librun/realm-forerunners but it still rendered as empty.

image

@vercel
Copy link

vercel bot commented Jun 29, 2023

@Tenari is attempting to deploy a commit to the Holium Team on Vercel.

To accomplish this, @Tenari needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@drunkplato
Copy link
Contributor

Finally got it working. There was a compile error in the design system which made the design system not update. Fixed that and tweaked some styling.

@drunkplato drunkplato merged commit e3233dd into master Jun 30, 2023
@drunkplato drunkplato deleted the RE-219/space-block branch June 30, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants