-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use background + space theme in standalone chat #1823
Conversation
Someone is attempting to deploy this pull request to the Holium Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be a cool feature to have, but think it should be a setting in the standalone chat settings page.
Chat background - Theme Color
or Space Wallpaper
Also, we should set a higher blur value.
And we should only set the background on the ChatLog, I don't think it works in New Chat or Settings
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Screen.Recording.2023-06-28.at.7.25.37.AM.movUpdated styling: using |
This looks much better, but we should still have a setting to toggle it. A preference I'd want here is to have the space chats have the wallpaper background, but group chats and dms to be solid. Defaults and settings options are below. Settings
|
@drunkplato @gdbroman In progress sqlite migration strategy is on this branch now, see Adding a new schema will consist of writing the migration in a new version in the |
This is ready now, can one of you test booting this branch locally? I believe the potential errors are handled, I just want verification this doesn't throw anything when going from the current state through initial migrations. I wiped my local electron store so I don't have access to that state right now. |
Works on my machine. I think Space-specific theming in standalone adds context which makes it easier to at a glance see which group DM you're in 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind giving a tl;dr of how the new migration service works @ajlamarc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just from a quick check, I think we need to default to not changing the entire theme when switching to a spaces chat -- if it goes from dark to light mode it is quite jarring. I would prefer to keep the theme for the interface the same, but change the theme within the chat log view.
We can make that a setting as well, I just know that I don't like the entire interface color changing when clicking between chats.
A standard B/W to match mobile with the space theming in chat is probably a good balance, but that is mixing more colors. Will need to try it out |
It's close to how a standard DB migration system works with up and down migrations. A new sqlite file stores the "current migration" data for the auth and ship files. That gets read, and if the number is less than the number in the setupAndMigrate call, then we loop and perform up migratjons until reaching the specified version. Note that SQLite doesn't support "create column if not exists" or "drop column if exists" so we are catching those specific errors in a helper function. This also works in reverse: setting a number less than the current migration performs the down migrations. Setting to 0 and booting would drop all the tables. |
I'm going to merge this because it's more on-brand with space theming. We can revisit having a different theming system for standalone chat, but that's out of scope for right now |
Description
Ticket: RE-295, RE-283
@gdbroman I'm in favor of adding spaces theming to standalone chat where sex appeal is more important - accessibility is not as good but still good in most cases. Merge at will
Screen.Recording.2023-06-23.at.8.12.09.AM.mov