Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use background + space theme in standalone chat #1823

Merged
merged 12 commits into from
Jul 8, 2023

Conversation

ajlamarc
Copy link
Contributor

@ajlamarc ajlamarc commented Jun 23, 2023

Description

Ticket: RE-295, RE-283

@gdbroman I'm in favor of adding spaces theming to standalone chat where sex appeal is more important - accessibility is not as good but still good in most cases. Merge at will

Screen.Recording.2023-06-23.at.8.12.09.AM.mov

Screenshot 2023-06-23 at 8 15 10 AM

@ajlamarc ajlamarc requested review from drunkplato and gdbroman June 23, 2023 12:17
@vercel
Copy link

vercel bot commented Jun 23, 2023

Someone is attempting to deploy this pull request to the Holium Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

Copy link
Contributor

@drunkplato drunkplato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be a cool feature to have, but think it should be a setting in the standalone chat settings page.

Chat background - Theme Color or Space Wallpaper

Also, we should set a higher blur value.

And we should only set the background on the ChatLog, I don't think it works in New Chat or Settings

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holium-com 🔄 Building (Inspect) Dec 13, 2024 8:31am
hosting-holium-com 🔄 Building (Inspect) Dec 13, 2024 8:31am
join-holium-com 🔄 Building (Inspect) Dec 13, 2024 8:31am
join-holium-com-1734078674680-OIgO 🛑 Canceled (Inspect) Dec 13, 2024 8:31am

@ajlamarc
Copy link
Contributor Author

ajlamarc commented Jun 28, 2023

Screen.Recording.2023-06-28.at.7.25.37.AM.mov

Updated styling: using rlm-dock-color as an overlay makes the background image less aggressive, and it's only used in the chat view now. Do we still want this to be configurable / non-default?

@drunkplato
Copy link
Contributor

Author

This looks much better, but we should still have a setting to toggle it.

A preference I'd want here is to have the space chats have the wallpaper background, but group chats and dms to be solid. Defaults and settings options are below.

Settings
Background:

  • Spaces chat: Wallpaper (default)
    • options: Wallpaper, Solid
  • Group chats & DM: Solid (default)
    • options: Wallpaper, Solid

@ajlamarc
Copy link
Contributor Author

ajlamarc commented Jul 1, 2023

@drunkplato @gdbroman In progress sqlite migration strategy is on this branch now, see MigrationService and MigrationDB. I would have liked to migrate to Prisma, but 1. That seems like a big PITA and 2. They still don't seem to support encrypted tables.

Adding a new schema will consist of writing the migration in a new version in the Migrations array, then bumping the targeted version in the setupAndMigrate call. With down migrations, we should be able to quickly roll back broken changes (and it should help with development). Let me know if any issues with the setup come to mind.

@ajlamarc
Copy link
Contributor Author

ajlamarc commented Jul 1, 2023

This is ready now, can one of you test booting this branch locally? I believe the potential errors are handled, I just want verification this doesn't throw anything when going from the current state through initial migrations.

I wiped my local electron store so I don't have access to that state right now.

@gdbroman
Copy link
Contributor

gdbroman commented Jul 3, 2023

This is ready now, can one of you test booting this branch locally? I believe the potential errors are handled, I just want verification this doesn't throw anything when going from the current state through initial migrations.

Works on my machine. I think Space-specific theming in standalone adds context which makes it easier to at a glance see which group DM you're in 👍

@gdbroman gdbroman requested a review from drunkplato July 3, 2023 09:39
gdbroman
gdbroman previously approved these changes Jul 3, 2023
Copy link
Contributor

@gdbroman gdbroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind giving a tl;dr of how the new migration service works @ajlamarc?

Copy link
Contributor

@drunkplato drunkplato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from a quick check, I think we need to default to not changing the entire theme when switching to a spaces chat -- if it goes from dark to light mode it is quite jarring. I would prefer to keep the theme for the interface the same, but change the theme within the chat log view.

We can make that a setting as well, I just know that I don't like the entire interface color changing when clicking between chats.

@ajlamarc
Copy link
Contributor Author

ajlamarc commented Jul 3, 2023

Just from a quick check, I think we need to default to not changing the entire theme when switching to a spaces chat -- if it goes from dark to light mode it is quite jarring. I would prefer to keep the theme for the interface the same, but change the theme within the chat log view.

We can make that a setting as well, I just know that I don't like the entire interface color changing when clicking between chats.

A standard B/W to match mobile with the space theming in chat is probably a good balance, but that is mixing more colors. Will need to try it out

@ajlamarc
Copy link
Contributor Author

ajlamarc commented Jul 3, 2023

Mind giving a tl;dr of how the new migration service works @ajlamarc?

It's close to how a standard DB migration system works with up and down migrations. A new sqlite file stores the "current migration" data for the auth and ship files.

That gets read, and if the number is less than the number in the setupAndMigrate call, then we loop and perform up migratjons until reaching the specified version. Note that SQLite doesn't support "create column if not exists" or "drop column if exists" so we are catching those specific errors in a helper function.

This also works in reverse: setting a number less than the current migration performs the down migrations. Setting to 0 and booting would drop all the tables.

@ajlamarc
Copy link
Contributor Author

ajlamarc commented Jul 8, 2023

I'm going to merge this because it's more on-brand with space theming. We can revisit having a different theming system for standalone chat, but that's out of scope for right now

@ajlamarc ajlamarc merged commit 02ef2a4 into master Jul 8, 2023
@ajlamarc ajlamarc deleted the standalone-chat-theming branch July 8, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants