Hosting byop fixes #1828
Hosting byop fixes #1828
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| if (!token || !serverId || !email || !provisionalShipId) return false; |
There was a problem hiding this comment.
This prevented all new users from uploading a pier, serverId and email were not set if you attempt onboarding in incognito mode or private browsing.
There was a problem hiding this comment.
Good catch, serverId will be undefined for new users, but email should be defined after Create Account.
There was a problem hiding this comment.
Both are unused and I don't have email in my local storage, just going to keep what is used. token and provisionalShipId
| @@ -73,7 +73,7 @@ export default function Login({ prefilledEmail, redirectAfterLogin }: Props) { | |||
| }; | |||
|
|
|||
| const onLogin = async (email: string, password: string) => { | |||
| const response = await thirdEarthApi.login(email, password); | |||
| const response = await thirdEarthApi.login(email, password, true); | |||
There was a problem hiding this comment.
Not loading the CSEK, caused all claim invite users to not be able to see the Download Realm page in some cases.
There was a problem hiding this comment.
Good, it's this check here:
| @@ -36,16 +36,37 @@ const HostingPresenter = () => { | |||
| const changeMaintenanceWindowModal = useToggle(false); | |||
| const ejectIdModal = useToggle(false); | |||
|
|
|||
| const identities = useMemo(() => ships.map((ship) => ship.patp), [ships]); | |||
| const identities = useMemo( | |||
| () => ships.map((ship) => ship.patp || ship.title), | |||
There was a problem hiding this comment.
BYOP ships should have a patp, is this covering some case where the user gets to the account page before the BYOP ship has finished booting?
There was a problem hiding this comment.
Yes. This has happened in two cases already.
Description
Reviewer Checklist