Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Disable system cursor" not immediately applied to webviews bug #1859

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

gdbroman
Copy link
Contributor

@gdbroman gdbroman commented Jul 3, 2023

Ticket: RE-294

Description

The fix is looping over all webcontents and applying the show/hide cursor CSS, not just browserwindows.

Before After
CleanShot.2023-07-03.at.17.41.21.mp4
CleanShot.2023-07-03.at.17.47.23.mp4

Reviewer Checklist

  • Pipeline passes
  • Docs have been added / updated
  • Tests have been added / updated
  • Has been refactored if necessary

@gdbroman gdbroman self-assigned this Jul 3, 2023
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated (UTC)
holium-com ⬜️ Ignored (Inspect) Jul 3, 2023 3:51pm
hosting-holium-com ⬜️ Ignored (Inspect) Jul 3, 2023 3:51pm
join-holium-com ⬜️ Ignored (Inspect) Jul 3, 2023 3:51pm

@gdbroman gdbroman added the bug Something isn't working label Jul 3, 2023
@gdbroman gdbroman marked this pull request as ready for review July 3, 2023 15:52
@gdbroman gdbroman merged commit ff9a967 into master Jul 3, 2023
@gdbroman gdbroman deleted the RE-294-system-cursor-bug branch July 3, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant