Forwarding chat messages #1864
Merged
Forwarding chat messages #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Tenari I think it's completely fine to use the png since it doesn't need dynamic colors, and might even be as large in file size, but if you want to try it, you can right-click> copy as SVG here: https://www.figma.com/file/3NMAfjSUcuJ9TasiLwocNt/Realm-2023?type=design&node-id=4998-29880&mode=design&t=4D6jloRkYSiZOPRY-4 |
gdbroman
reviewed
Jul 7, 2023
Comment on lines
+323
to
+325
| <image | ||
| width="24" | ||
| height="24" |
There was a problem hiding this comment.
Just create a file called CourierIcon that exports this, no need to shoehorn an image into the SVG component, none of the props will work on this anyway.
There was a problem hiding this comment.
When I tried to export the icon from figma as SVG it gave me this
also, opacity prop works, as do some others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: RE-157
still left to do: