Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank Trove & Lexicon #1900

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix blank Trove & Lexicon #1900

merged 3 commits into from
Jul 12, 2023

Conversation

gdbroman
Copy link
Contributor

@gdbroman gdbroman commented Jul 12, 2023

  • Don't clear app-catalog on init()
  • Updating Realm client to look for app IDs os-lexicon & os-trove
  • Lastly, fixing the blank window (it was a react-router-dom issue, we need to automatically fall back to /spacePath):

CleanShot 2023-07-12 at 15 19 55@2x

@gdbroman gdbroman added the bug Something isn't working label Jul 12, 2023
@gdbroman gdbroman self-assigned this Jul 12, 2023
@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
holium-com ⬜️ Ignored (Inspect) Jul 12, 2023 8:19pm
hosting-holium-com ⬜️ Ignored (Inspect) Jul 12, 2023 8:19pm
join-holium-com ⬜️ Ignored (Inspect) Jul 12, 2023 8:19pm

@gdbroman gdbroman force-pushed the fix-scroll-lexicon-and-trove branch 6 times, most recently from 146194d to fb35437 Compare July 12, 2023 17:20
@gdbroman gdbroman closed this Jul 12, 2023
@gdbroman gdbroman force-pushed the fix-scroll-lexicon-and-trove branch from fb35437 to 72ccdaf Compare July 12, 2023 17:37
@gdbroman gdbroman reopened this Jul 12, 2023
@gdbroman gdbroman force-pushed the fix-scroll-lexicon-and-trove branch from 94ab26f to 5ac46d1 Compare July 12, 2023 17:38
@gdbroman gdbroman force-pushed the fix-scroll-lexicon-and-trove branch 5 times, most recently from ceb6215 to 3bcff0d Compare July 12, 2023 20:05
@gdbroman gdbroman force-pushed the fix-scroll-lexicon-and-trove branch from 3bcff0d to 29a1fc1 Compare July 12, 2023 20:18
@gdbroman gdbroman merged commit 254305f into master Jul 12, 2023
@gdbroman gdbroman deleted the fix-scroll-lexicon-and-trove branch July 12, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant