Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE-323 allow tall bubble to be scrolled #1903

Merged
merged 1 commit into from
Jul 13, 2023
Merged

RE-323 allow tall bubble to be scrolled #1903

merged 1 commit into from
Jul 13, 2023

Conversation

Tenari
Copy link
Contributor

@Tenari Tenari commented Jul 12, 2023

Ticket: RE-323

Chat forwarding bug

Reviewer Checklist

  • Pipeline passes
  • Docs have been added / updated
  • Tests have been added / updated
  • Has been refactored if necessary

@vercel
Copy link

vercel bot commented Jul 12, 2023

@Tenari is attempting to deploy a commit to the Holium Team on Vercel.

To accomplish this, @Tenari needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@Tenari Tenari requested a review from gdbroman July 12, 2023 16:07
@gdbroman
Copy link
Contributor

gdbroman commented Jul 12, 2023

I'd rather truncate tall bubbles than have them overflow. Have you pulled master? Perhaps this is another problem, but that's what the span.bubble-fragment css was for.

@gdbroman
Copy link
Contributor

Ah I see this is for images. In that case, we can change the image height, making the whole bubble smaller.

@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
holium-com ⬜️ Ignored (Inspect) Jul 13, 2023 3:03pm
hosting-holium-com ⬜️ Ignored (Inspect) Jul 13, 2023 3:03pm
join-holium-com ⬜️ Ignored (Inspect) Jul 13, 2023 3:03pm

@gdbroman gdbroman force-pushed the RE-323_forwarding branch from 75e739c to 6021d11 Compare July 13, 2023 15:02
@gdbroman
Copy link
Contributor

CleanShot 2023-07-13 at 17 02 20@2x

@gdbroman gdbroman merged commit 12209a3 into master Jul 13, 2023
@gdbroman gdbroman deleted the RE-323_forwarding branch July 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants