RE-331 fix DM forwarded from title issue #1928
Conversation
|
@Tenari is attempting to deploy a commit to the Holium Team on Vercel. To accomplish this, @Tenari needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
| @@ -270,6 +275,7 @@ export const Bubble = ({ | |||
| /> | |||
| )} | |||
| <Text.Custom | |||
| id={id} | |||
There was a problem hiding this comment.
Passing the same id to multiple DOM elements is a bad practice since it's supposed to be unique. I think switching to className would be a rather simple refactor, if not – let's leave it.
There was a problem hiding this comment.
the reason we pass the same id is because context menu needs it. we could change the way context menu works, but that was outside the scope of what I was trying to do here, since that would touch the whole application, not just chat.
There was a problem hiding this comment.
@gdbroman I made a ticket to fix the id issue here: https://holium.atlassian.net/browse/RE-378
There was a problem hiding this comment.
Yea. Did you try setting pointer-events: none on these children instead of passing the id? That way the click should just pass through until it hits the parent container. @Tenari
There was a problem hiding this comment.
i did not try that... I can tinker with it today
I also fixed the righ-click menu on chat messages by passing
idthrough the tree