Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE-398 remove-many for bulk delete a bunch of rows by id (must be sam… #1938

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

Tenari
Copy link
Contributor

@Tenari Tenari commented Jul 25, 2023

…e path and type)

Ticket: RE-398

remove-many poke for bedrock

Reviewer Checklist

  • Pipeline passes
  • Docs have been added / updated
  • Tests have been added / updated
  • Has been refactored if necessary

@Tenari Tenari requested a review from gdbroman July 25, 2023 20:58
@vercel
Copy link

vercel bot commented Jul 25, 2023

@Tenari is attempting to deploy a commit to the Holium Team on Vercel.

To accomplish this, @Tenari needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Copy link
Contributor

@gdbroman gdbroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir. So the JSON payload would be:

{
        remove-many: {
          ids: [x, y, z],
          path: 'path',
          type: 'foo',
        },
      }
}

?

Copy link
Contributor

@gdbroman gdbroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Saw the Postman example now. Again, this is not a guaranteed way to clean up people's edit history in bedrock. Some rows risk remaining, but it works for now.

@gdbroman gdbroman merged commit 3befe02 into master Jul 26, 2023
@gdbroman gdbroman deleted the RE-398_improve-bedrock branch July 26, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants