Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bedrock spaces paths syncing better #1964

Merged
merged 2 commits into from
Aug 3, 2023
Merged

bedrock spaces paths syncing better #1964

merged 2 commits into from
Aug 3, 2023

Conversation

Tenari
Copy link
Contributor

@Tenari Tenari commented Aug 2, 2023

I found some minor issues, but I was never able to reproduce someone joining a space and NOT being added to the bedrock path for that space.

so I'm not actually confident this will fix the issue gus encountered, but it is a good change

@Tenari Tenari requested a review from gdbroman August 2, 2023 19:24
@vercel
Copy link

vercel bot commented Aug 2, 2023

@Tenari is attempting to deploy a commit to the Holium Team on Vercel.

To accomplish this, @Tenari needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@gdbroman gdbroman added the build Build a merged PR (e.g merge into master or production) label Aug 2, 2023
@gdbroman
Copy link
Contributor

gdbroman commented Aug 3, 2023

#1 I've tried reproducing the not-being-added-to-path bug on the testnet planets too, but without luck, it only remains a problem on my main ship. We could deploy this PR to prod if you think it has the potential of fixing it.

#2 I HAVE been able to reproduce the SSE bug, using two testnet planets: It's a slightly new case, although fundamentally it's the same issue, where the add-row event IS successfully emitted, but the del-row is NOT (0:05 in video), causing the two planets' notes to be briefly out-of-sync until Notes is closed & reopened and the scry is made:

CleanShot.2023-08-03.at.12.35.45.2.mp4

@gdbroman gdbroman force-pushed the bedrock-spaces-sync branch from a1d7a07 to 4dba226 Compare August 3, 2023 19:35
@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
holium-com ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 7:39pm
hosting-holium-com ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 7:39pm
join-holium-com ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 7:39pm

@gdbroman gdbroman force-pushed the bedrock-spaces-sync branch from 6964d0b to 4dba226 Compare August 3, 2023 20:38
@gdbroman gdbroman merged commit 3bcc484 into master Aug 3, 2023
@gdbroman gdbroman deleted the bedrock-spaces-sync branch August 3, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build a merged PR (e.g merge into master or production)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants