Make /provisional-ship-entry non-blocking #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
gdbroman
added
bug
gdbroman
changed the title
gdbroman
force-pushed
the
hosting-fix-provisional-ship-entry
branch
from
285f5a8 to
91697b1
Compare
|
Merging this now as I'm making a detour back to hosting to implement SFTP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint
/provisional-ship-entryis timing out – that's being investigated. EDIT: it's fixed now.Meanwhile, the onboarding should proceed from the payment screen without waiting for a response from
/provisional-ship-entry. If they've paid, server-downtime should not prompt users to pay multiple times, better the flow fails later.Example
CleanShot.2023-09-21.at.19.17.22.mp4
I've re-run through the regular and BYOP flow in TEST.