-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload pier with SFTP #2062
Merged
Merged
Upload pier with SFTP #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
gdbroman
force-pushed
the
RE-487-sftp
branch
2 times, most recently
from
September 28, 2023 13:27
d9cec7d
to
56bb439
Compare
gdbroman
force-pushed
the
RE-487-sftp
branch
from
September 28, 2023 14:52
958b444
to
c672080
Compare
Just ran the request flow by Johnathan and Liam. Merging, and doing two tests in prod: one monthly byop-p, and one monthly planet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: RE-487
Description
Here we implement SFTP in the BYOP onboarding flow in favor of the less reliable web upload.
Docs have been updated: https://docs.holium.com/main/hosting/upload-pier-with-sftp
Affected steps
redirect.mp4
Reviewer Checklist