Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't assign URL object to string #2063

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix can't assign URL object to string #2063

merged 1 commit into from
Sep 28, 2023

Conversation

gdbroman
Copy link
Contributor

@gdbroman gdbroman commented Sep 28, 2023

Ticket: RE-

Description

This was caught by CI, haven't personally seen it cause an error in prod though.

Reviewer Checklist

  • Pipeline passes
  • Docs have been added / updated
  • Tests have been added / updated
  • Has been refactored if necessary

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
holium-com ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 1:50pm
hosting-holium-com ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 1:50pm
join-holium-com ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 1:50pm

@gdbroman gdbroman requested a review from Tenari September 28, 2023 13:49
@gdbroman gdbroman self-assigned this Sep 28, 2023
@gdbroman gdbroman added the bug Something isn't working label Sep 28, 2023
@subnet-arts subnet-arts merged commit 4b5bee4 into master Sep 28, 2023
@subnet-arts subnet-arts deleted the fix-url-object branch September 28, 2023 14:49
Copy link
Contributor

@subnet-arts subnet-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this got by. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants