revert: fix(aws-ecs): "broken splunk-logging tag-option in fargate …

…platform version 1.4 (aws#13882)" (aws#13892)

This reverts commit e9d9299.

Unfortunately the above commit leads to broken deployments that are caused by behaviors upstream (i.e. in the ECS backend):

> Resource handler returned message: "Invalid request provided: Create TaskDefinition: Log driver splunk disallows options: splunk-tag (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Request ID: d13abe56-36fa-4e81-b980-bf83789d4d0d; Proxy
: null)" (RequestToken: 546a74e2-a2eb-ef75-43e7-231fe8927096, HandlerErrorCode: InvalidRequest)

This means however, that the buggy behavior mentioned in aws#13881 persists.
I am in communication with AWS support on this issue and will keep you posted.

Sorry to have caused that mess. I should have marked the PR aws#13882 as draft before everything was clear.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

packages/@aws-cdk/aws-ecs/lib/log-drivers/splunk-log-driver.ts

@@ -145,7 +145,6 @@ export class SplunkLogDriver extends LogDriver {
         'splunk-verify-connection': this.props.verifyConnection,
         'splunk-gzip': this.props.gzip,
         'splunk-gzip-level': this.props.gzipLevel,
-        'splunk-tag': this.props.tag,
         ...renderCommonLogDriverOptions(this.props),
       }),
     };

packages/@aws-cdk/aws-ecs/test/splunk-log-driver.test.ts

@@ -103,35 +103,4 @@ nodeunitShim({
 
     test.done();
   },
-
-  'create a splunk log driver using splunk-tag property when tag is defined'(test: Test) {
-    // WHEN
-    td.addContainer('Container', {
-      image,
-      logging: ecs.LogDrivers.splunk({
-        token: cdk.SecretValue.secretsManager('my-splunk-token'),
-        url: 'my-splunk-url',
-        tag: 'abc',
-      }),
-      memoryLimitMiB: 128,
-    });
-
-    // THEN
-    expect(stack).to(haveResourceLike('AWS::ECS::TaskDefinition', {
-      ContainerDefinitions: [
-        {
-          LogConfiguration: {
-            LogDriver: 'splunk',
-            Options: {
-              'splunk-token': '{{resolve:secretsmanager:my-splunk-token:SecretString:::}}',
-              'splunk-url': 'my-splunk-url',
-              'splunk-tag': 'abc',
-            },
-          },
-        },
-      ],
-    }));
-
-    test.done();
-  },
 });