Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keypadlinc_relay device configured as keypadlinc in items.mht crashes mh #135

Closed
marcmerlin opened this issue Mar 23, 2013 · 3 comments
Closed

Comments

@marcmerlin
Copy link
Collaborator

I had this when starting mh when my keypadlinc was misconfigured as keypadlinc instead of keypadlinc_relay:

Can't call method "_process_command_stack" on unblessed reference at ../lib/Insteon_PLM.pm line 625.
at ./mh line 31
main::ANON('Can't call method "_process_command_stack" on unblessed refe...') called at ../lib/Insteon_PLM.pm line 625
Insteon_PLM::parse_data('Insteon_PLM=HASH(0xa4cbd90)', '02564207de8b025806') called at ../lib/Insteon_PLM.pm line 164
Insteon_PLM::check_for_data('Insteon_PLM=HASH(0xa4cbd90)') called at ../lib/Insteon/BaseInterface.pm line 11
Insteon::BaseInterface::check_for_data() called at ./mh line 1402
main::run_hooks
('MainLoop_pre') called at (eval 335) line 5
main::MainLoop_pre_hooks() called at ./mh line 1515
main::check_for_action called at ./mh line 3296
main::monitor_commands called at ./mh line 6713

@krkeegan
Copy link
Collaborator

I also don't think I have enough to figure this one out. Marc, what version are you running? The line number doesn't match with the error message in Michael's version of this file since the beginning of March.

If you have longer print_logs for this, that might help.

@marcmerlin
Copy link
Collaborator Author

gargamel:/var/local/src/misterhouse/mh# git remote -v
origin git://github.com/mstovenour/misterhouse.git (fetch)
origin git://github.com/mstovenour/misterhouse.git (push)
gargamel:/var/local/src/misterhouse/mh# git status

On branch i2_aldb_support

nothing to commit (working directory clean)

I agree the line number doesn't fully match. Did mh say 625 instead of 630?

gargamel:/var/local/src/misterhouse/mh# nl lib/Insteon_PLM.pm | grep -5 625
620 my $failure_group = substr($message_data,0,2);
621 my $failure_device = substr($message_data,2,6);
622
623 &::print_log("[Insteon_PLM] DEBUG2: Received all-link cleanup failure from device: "
624 . "$failure_device and group: $failure_group") if $main::Debug{insteon} >= 2;
625
626 my $failed_object = &Insteon::get_object($failure_device,'01');
627 my $message = new Insteon::InsteonMessage('all_link_direct_cleanup', $failed_object,
628 $self->active_message->command, $failure_group);
629 push(@{$$failed_object{command_stack}}, $message);
630 $failed_object->_process_command_stack();

@marcmerlin
Copy link
Collaborator Author

I restarted mh with mh device misconfigured as keypadlinc and the error did not re-occur.
Given that, it's probably ok to close this for now.

krkeegan added a commit to krkeegan/misterhouse that referenced this issue Mar 26, 2013
Provides a warning message if a root device cannot be found.  Such as when a user defines a keypadlinc button but does not define the root keypadlinc.  May also occur when there is a typo in the device id.

This should help users to catch errors such as issues hollie#134, hollie#135, and hollie#136.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants