Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insteon: Parser for Checking Commands Sent to PLM has a Couple Errors #170

Closed
krkeegan opened this issue Apr 29, 2013 · 0 comments
Closed

Insteon: Parser for Checking Commands Sent to PLM has a Couple Errors #170

krkeegan opened this issue Apr 29, 2013 · 0 comments
Assignees
@krkeegan
Labels
bug

Comments

@krkeegan
Copy link
Collaborator

Caused by Pull #100

  1. Commands need to be converted to uppercase, otherwise any command with a letter, such as 026a, does not match the hash key.
  2. The insteon_send commands can be 1 of 2 lengths, extended commands are throwing an error as too long.
@ghost ghost assigned krkeegan Apr 29, 2013
krkeegan added a commit to krkeegan/misterhouse that referenced this issue Apr 29, 2013
@krkeegan
Insteon: Fix Error in PLM Message Integrity Check Logic
aaadbb5 
Fix bugs in which PLM commands with a letter were rejected as being too long. Notably this prevented the scanning of the PLM link table.

Also fix bug which prevented MH from sending extended length messages to the PLM.

Fixes Issues
hollie#170
mstovenour/misterhouse#14
@krkeegan krkeegan mentioned this issue Apr 29, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krkeegan krkeegan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krkeegan