INSTEON lights treated differently in web interface; cannot dim/brighten INSTEON lights

[peloy]

• Icons for INSTEON lights in the web interface are different than icons for X10 lights.
• One cannot dim or brighten an INSTEON dimmable light by clicking on the left or right side of a light icon.
• There is an attempt in web/bin/button.pl to disable the button image cache, but it is not working due to a logic error.

[peloy]

Hello, looking for feedback on a patch to fix these issues. My work is here:

https://github.com/peloy/misterhouse/branches/fix_issue_212

[peloy]

By the way, to be able to dim/brighten INSTEON lights, the patch relies on the dim levels being part of the device's state list. For instance, I have this in one of my user code files:

$dining_room_dim->set_states('off', '20', '40', '60', '80', 'on'); # noloop

I think that should be done by the INSTEON stack for dimmable lights, but that's a separate issue.

[mstovenour]

I'm looking at this now. I think you've done a good job identifying and fixing the Insteon support here. I would like to test this out and then add a quick additional enhancement to get the dimmable Insteon devices to utilize the insteon_menu_states ini parameter. If you will issue a pull request against hollie it will make sure you get credit (and blame :) for your changes. Not being a Git ninja I don't know how to otherwise give you credit.

[mstovenour]

I created a pull request that provides Eloy's changes plus additional fixes. Let me know if there are any issues with the changes.