Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insteon: Link_to_Interface is Not Working on Child Objects #274

Closed
krkeegan opened this issue Oct 11, 2013 · 2 comments
Closed

Insteon: Link_to_Interface is Not Working on Child Objects #274

krkeegan opened this issue Oct 11, 2013 · 2 comments
Assignees
@krkeegan
Labels
bug

Comments

@krkeegan
Copy link
Collaborator

Sync links works fine, so most of us have not noticed this. But the individual command link_to_interface is not working on non_root objects. Not sure if this was always broken or if I did this. I think it does not work because the code for dealing with non-root objects is contained in DeviceController and most all devices are BaseDevices first which also contains a link_to_interface routine.

The solution is likely to move any specific code out of DeviceController and put it into BaseDevice.
@ghost ghost assigned krkeegan Oct 11, 2013
krkeegan added a commit to krkeegan/misterhouse that referenced this issue Oct 11, 2013
@krkeegan
Insteon: Enabling Link_To_Interfaces for Child Objects in BaseDevice
aac169b 
Enabled group and data3 determination if not specified.

Based off of Insteon_I2CS_Linking Branch so as not to require a manual merge.  Need to merge that branch first.

Closed hollie#274
@krkeegan krkeegan mentioned this issue Oct 11, 2013
Merged
@krkeegan
Copy link
Collaborator Author

Likely need to check on the unlink_from_interface routines.

@krkeegan
Copy link
Collaborator Author

Also need to add surrogate links for KPL devices, we never did that before, but the initial logic for the code was there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krkeegan krkeegan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krkeegan