Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a remote NCID server for caller ID #393

Closed
rudybrian opened this issue Mar 28, 2014 · 3 comments
Closed

Add support for a remote NCID server for caller ID #393

rudybrian opened this issue Mar 28, 2014 · 3 comments

Comments

@rudybrian
Copy link
Contributor

The current NCID implementation only supports reading logs from a local NCID server, and doesn't have the full set of features possible with a modem directly connected to (and managed by) MH.

I propose adding support to Telephony_Interface.pm to allow use of a remote NCID server.

@rudybrian
Copy link
Contributor Author

The first commit seems to be working, but is still a bit rough around the edges.

To use this, I have the following entries in mh.private.ini:

callerid_port = localhost:3333
callerid_name = acheron-ncid
callerid_type = ncid

I have modified the regex used for type ncid to work with the current NCID format. At some point it changed from

CID:*DATE*10202003*TIME*0019*NMBR*2125551212*MESG*NONE*NAME*INFORMATION*

to

CID: *DATE*03272014*TIME*1734*LINE*1234*NMBR*2125551212*MESG*NONE*NAME*OUT-OF-AREA*

This change should also allow code/public/callerid_ncid.pl to work again even though it is now functionally redundant.

rudybrian added a commit to rudybrian/misterhouse that referenced this issue Mar 28, 2014
rudybrian added a commit to rudybrian/misterhouse that referenced this issue Mar 31, 2014
@rudybrian
Copy link
Contributor Author

I added some logic in the last commit that will allow MH to reconnect to an NCID server if connectivity is interrupted.

This seems to be working well on my test system, and I would welcome some testing/recommendations prior to submitting a pull request.

@hollie
Copy link
Owner

hollie commented Aug 10, 2014

Was merged into master, closing this issue.

a5a3f95

@hollie hollie closed this as completed Aug 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants