Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insteon PLM unresponsive using master #413

Closed
Gribnif opened this issue May 24, 2014 · 8 comments
Closed

Insteon PLM unresponsive using master #413

Gribnif opened this issue May 24, 2014 · 8 comments
Assignees

Comments

@Gribnif
Copy link
Contributor

Gribnif commented May 24, 2014

After installing master I started getting these messages during initialization:

05/23/14 09:21:48 PM [Insteon_PLM] WARN: received Bad Command Error from PLM for obj=$PLM; interface_data=

05/23/14 09:21:48 PM [Insteon_PLM] ERROR: Received data did not start with a valid prefix. Trimming to:

and no further PLM messages get logged.

I did a git bisect and traced it down to commit e107334306f1. Let me know if there's more I can do to help debug.

@krkeegan
Copy link
Collaborator

I can't be sure what caused the error, but I just merged a fix that might do it. If things are still broken, please increase the debug to level 4 so I can see what the message is that it gets stuck on.

@krkeegan krkeegan self-assigned this Jun 13, 2014
@Gribnif
Copy link
Contributor Author

Gribnif commented Jun 17, 2014

I tried the latest master, and the problem persists.

I also think I need more specific instructions on how to set the debug level. I tried adding "-debug 4" to the commandline, but that made no difference.

@JaredF
Copy link
Collaborator

JaredF commented Jun 17, 2014

@Gribnif, put the following line in your mh.ini file and reload:

debug=insteon:4

@Gribnif
Copy link
Contributor Author

Gribnif commented Jun 17, 2014

06/16/14 10:57:04 PM [Insteon_PLM] DEBUG3: Received PLM raw data: 02600fdde9030b8506
06/16/14 10:57:04 PM [Insteon_PLM] DEBUG3: Processing PLM raw data: 02600fdde9030b8506
06/16/14 10:57:04 PM [Insteon_PLM] DEBUG4:
         PLM Command: (0260) plm_info
       PLM Device ID: 0f:dd:e9
     Device Category: 03:0b
            Firmware: 85
        PLM Response: (06) ACK

06/16/14 10:57:04 PM [Insteon_PLM] WARN: received Bad Command Error from PLM for obj=$PLM; interface_data=
06/16/14 10:57:04 PM [Insteon_PLM] DEBUG3: Processing PLM raw data: dde9030b8506
06/16/14 10:57:04 PM [Insteon_PLM] ERROR: Received data did not start with a valid prefix.  Trimming to:

krkeegan added a commit to krkeegan/misterhouse that referenced this issue Jun 17, 2014
@krkeegan
Copy link
Collaborator

Too funny. Although I am sure @Gribnif doesn't find it funny.

So, the first prefix of your PLM if 0F which is the same code as a "bad command." Normally something like this wouldn't matter. But the initial "PLM Info" command that we send is somewhat unique.

I have reordered the manner in which the messages are parsed. This should fix your issue.

@Gribnif
Copy link
Contributor Author

Gribnif commented Jun 17, 2014

That fixed it. Thanks!

@Gribnif Gribnif closed this as completed Jun 17, 2014
@JaredF
Copy link
Collaborator

JaredF commented Jun 17, 2014

Wow, great catch @krkeegan! What are the odds, huh??

@krkeegan
Copy link
Collaborator

Yeah, without the debug details I would not have figured it out. Although, in hindsight now it makes total sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants