Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insteon: Don't Scan an ALDB record not in use #46

Closed
krkeegan opened this issue Jan 28, 2013 · 1 comment
Closed

Insteon: Don't Scan an ALDB record not in use #46

krkeegan opened this issue Jan 28, 2013 · 1 comment

Comments

@krkeegan
Copy link
Collaborator

Somewhere around AllLinkDatabase.pm line 402.

The ALDB flag includes an "in use" flag. Why do we keep scanning the remaining bits if we the flag tells us the record is not in use?
@krkeegan
Copy link
Collaborator Author

krkeegan commented Feb 2, 2013

I looked into this more, MH gathers all of the link information. But when it saves the state it dumps it all and just saves the address as empty.

Can anyone see any reason to scan the rest of an address if the first flag identifies it as being empty? Nothing in the current code relies on this feature and I can't really see using it in the future. Stopping after the link_flag would save 7 peek requests for every empty address.

krkeegan added a commit to krkeegan/misterhouse that referenced this issue Feb 2, 2013
@krkeegan
Fix typos in fix for issue hollie#46
27c969b
krkeegan added a commit that referenced this issue Feb 6, 2013
@krkeegan
Merge pull request #51 from krkeegan/fix_issue_46
bebd1e0 
Fix issue #46 - Stop Scanning Out of Use Entries

I have tested this for a few days and it is certainly faster, but for users with only a few empty addresses will see only slight speed increases.  I double checked and confirmed that MH has no code for enabling disabled links.
@krkeegan krkeegan closed this as completed Feb 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krkeegan