Insteon: Deleting a Controller Record from the PLM for an otherwise valid PLM Scene Causes an error

[krkeegan]

This is an odd and very specific error. To recreate you need to do the following:

1. A PLM controlled scene synced to two or more devices.
2. Delete one device as a responder to the scene, but leave the scene defined and the other device still linked.

If you run AUDIT Delete Orphans, the PLM section will contain a message similar to the following:
(AUDIT) Delete orphan controller link from PLM to $s_ma_room_lt_s1 because no SCENE_MEMBER entry could be found in items.mht for INSTEON_ICONTROLLER: $surrogate_s_st_lt_ma_b

But when you run Delete Orphans you will get the following error:
error during scan callback Can't locate object method "device_id" via package "Insteon::ALDB_PLM" at

Yet if you completely delete the PLM scene, Delete Orphans will work correctly.

A close inspection reveals the problem is in the ALDB_PLM Delete_Orphans subroutine around line 1971. The delete_req hash is all messed up, it should be identical to the delete_req has on or about line 1899, which is the request for a deleted plm scene.

I have a fix and will post later tonight.