ADLB_i1 callbacks switch to wrong namespace?

[mstovenour]

I noticed that several of the ALDB_i1 functions switch to the AllLinkDataBase namespace once the call backs are completed. Honestly I don't fully understand the implications. Is this the correct behavior or should all the ALDB_i1 functions switch back to the ALDB_i1 namespace?
Example (1 of 3)
sub delete_link
....
package main;
eval($link_parms{callback});
package Insteon::AllLinkDataBase;

[krkeegan]

I don't think there is any legitimate reason for this, I am 99% sure this
is a typo. Things continue to work fine because MH doesn't make use of
namespace variables very much. Almost all of the variables are saved
within an object.

On Sat, Feb 16, 2013 at 11:58 AM, Michael Stovenour <
notifications@github.com> wrote:

I noticed that several of the ALDB_i1 functions switch to the
AllLinkDataBase namespace once the call backs are completed. Honestly I
don't fully understand the implications. Is this the correct behavior or
should all the ALDB_i1 functions switch back to the ALDB_i1 namespace?
Example (1 of 3)
sub delete_link
....
package main;
eval($link_parms{callback});
package Insteon::AllLinkDataBase;

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/80.

[mstovenour]

OK, I can clean it up later when consolidating the i1 and i2 code. If anyone decides to look into issue (#57) then this should probably be cleaned up as part of that work before doing a lot of testing.

[krkeegan]

Pull #69 fixed known issues of this.

[mstovenour]

There are multiple instances of this in Insteon::ALDB_i1 That's where I first noticed it.

[krkeegan]

Can we call this closed? We seem to have tackled all of the known ones.

[mstovenour]

I think we have this one covered