Remove no_hop_increase flag from NACK logic #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages that are NACKed are dropped not resent. So there is no concern that a hop_increase will be recorded.
|
Was both incorrectly coded, as Michael pointed out, and unnecessary. Michael, I don't want to cause more issues, so let me know when you would like this merged. |
krkeegan
added a commit
that referenced
this pull request
Mar 9, 2013
Remove no_hop_increase flag from NACK logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages that are NACKed are dropped not resent. So there is no concern that a hop_increase will be recorded.