Updated MHL to run from same directory as mhl script

[PrimusNZ]

Updated MHL to allow both absolute and relative paths

E.g.
Instead of running:
cd /opt/misterhouse/bin
./mhl

You can now run:
/opt/misterhouse/bin/mhl
OR from the misterhouse root directory:
./bin/mhl

[peloy]

Hi Ryan,

On 03/07/2013 06:37 PM, Ryan Davies wrote:

Updated MHL to allow both absolute and relative paths

E.g.
Instead of running:
cd /opt/misterhouse/bin
./mhl

You can now run:
/opt/misterhouse/bin/mhl
OR from the misterhouse root directory:
./bin/mhl

+# Set current working directory to location of this script (bin/)
+cd "$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+

This only works if /bin/sh is bash. On some distributions, /bin/sh is a
POSIX-compliant shell, like dash, that does not support some of the
extra features supported by the Bash shell.

Applying this patch means that mhl would break for those using a
non-Bash /bin/sh.

In addition, the directory where mhl resides could be read-only.

I'd change mhl so the temp. files are written to another directory, like
MH's data_dir or /tmp, and so the mh binary is run with an absolute path
instead of just "perl mh" as it is currently being run by mhl.

Disclaimer: I don't use mhl.

Cheers,

Eloy Paris.-

---

    You can merge this Pull Request by running

git pull https://github.com/ProGEEK/misterhouse mhl

Or view, comment on, or merge it at:

#110

    Commit Summary

• Updated MHL to run from same directory as mhl script

  File Changes
  

• M bin/mhl
  https://github.com/hollie/misterhouse/pull/110/files#diff-0 (3)

  Patch Links:
  

• https://github.com/hollie/misterhouse/pull/110.patch

• https://github.com/hollie/misterhouse/pull/110.diff

[PrimusNZ]

In theory replacing ${BASH_SOURCE[0]} with $0 should work, i'll update the script

[peloy]

On 03/07/2013 07:25 PM, Ryan Davies wrote:

In theory replacing ${BASH_SOURCE[0]} with $0 should work, i'll update
the script

Yes, I've tested and that works with Dash.

Cheers,

Eloy Paris.-

[PrimusNZ]

Ive comitted the change.

I agree that the mh startup file needs to be written elsewhere, however i
dont know how we would correctly get the MH data dir, as it might not
always be a full path, Might be worth looking at switching it to write to
/tmp for now

R

On Fri, Mar 8, 2013 at 2:32 PM, Eloy Paris notifications@github.com wrote:

On 03/07/2013 07:25 PM, Ryan Davies wrote:

In theory replacing ${BASH_SOURCE[0]} with $0 should work, i'll update
the script

Yes, I've tested and that works with Dash.

Cheers,

Eloy Paris.-

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/110#issuecomment-14597785
.

[krkeegan]

Eloy, I agree with your concerns that the directory may be read only. However, am I correct in that the read only problem exists even absent this patch? If so I think we can commit this and note that issue for a future patch.

[peloy]

On 03/08/2013 08:23 PM, krkeegan wrote:

Eloy, I agree with your concerns that the directory may be read only.
However, am I correct in that the read only problem exists even absent
this patch?

Yes, correct.

If so I think we can commit this and note that issue for a
future patch.

Sounds good!

Cheers,

Eloy.-