Fix issue 139: lib/Insteon/ file fixes

[jame]

1. Add a shabang line to MessageDecoder_test.pl like this: "#!/usr/bin/perl -w".
2. Remove the executable mode setting from the *.pm files.

[mstovenour]

Did you test the decoder after making this change? I'm not sure about the -w. "should" be fine but needs to be tested.

[jame]

The same issues come up using the warnings pragma whether the test script is run at the command line like this:

perl -w MessageDecoder_test.pl

as it does running with something like this as the first line.

#!/usr/bin/perl -w

So no, there appears to be no difference in the scripts output.

[jame]

Note that what that is coming up with on my system (Debian Wheezy) are multiple instances of the following:

Use of uninitialized value in concatenation (.) or string at ../Insteon/MessageDecoder.pm line 520.
Use of uninitialized value in multiplication (*) at ../Insteon/MessageDecoder.pm line 521.
Use of uninitialized value in multiplication (*) at ../Insteon/MessageDecoder.pm line 524.

Mostly of the latter two. If someone else hasn't had a chance to look at those, I could take a look...

[mstovenour]

you get those errors when using MH with Insteon:4 debug level or you get those errors when using MessageDecoder_test.pl? And only when you have the -w or does this occur w/o the -w option? I use a slightly older Debian distribution (as well as Windows 7 / Activestate Perl 5.12) and have not seen those errors. Maybe it is specific to the message you are decoding? If so can you show me that message's hex data?

[jame]

They show up when running MessageDecoder_test.pl, and when the warnings pragma is being used.

[jame]

Note that I think that the issues that using the warnings pragma is finding in MessageDecoder.pm is separate from what I originally intended #139 to address and #140 to fix. If it's not actually on someones todo list already (and I figured it was since I also assume by default that the warnings pragma is being used for public code) I could open a new bug for it and include the results I've found.

[jame]

Same issues result from using the warnings pragma when running the MessageDecoder_test.pl script on Debian v6.05 system, which has Perl v5.10.
If you also run it in the same way, I would be surprised if the same issues with the module does not come up.

[mstovenour]

I don't think there is a culture of using warnings in the misterhouse project. I would be surprised if mh its self will run cleanly with warnings turned on. That being said I agree that something as standalone as the message decoder "could" be cleaned up to run with warnings enabled. I'll work on it when I get time. In the mean while you could issue a new pull request w/o the -w otherwise I think this pull request should wait until I get time to fix the warnings.

[jame]

I don't see a problem with this pull request being held until the module has been fixed. I'll open a separate bug for the Issues found in the Insteon/MessageDecoder.pm module.

[krkeegan]

Merged in as #208