Insteon: Log Output if PLM Parser Drops a Duplicate Messages #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered by @peloy, the PLM Parser was silently dropping duplicate messages sequentially received in the same pass. This adds a debug3 message to the log when such messages are dropped. Partial fix for hollie#186
…eived at the Same Time PLM Decoder will not decode each message if multiple are received in one check data request. The only place that could create a hiccup, is if the PLM Parser has a bug. Since we now rely on the PLM Parser to first identify a valid message before asking the decoder to decode it, we rely on the PLM Parser to accurately discover messages. We still display the raw message, so the information is not lost, but we will not have a nice display of the message. I don't see this as a big deal, if the PLM Parser is missing messages we would likely have other problems anyways. Fixes the remainder of hollie#186
Conflicts: lib/Insteon_PLM.pm
krkeegan
added a commit
that referenced
this pull request
May 21, 2013
Insteon: Log Output if PLM Parser Drops a Duplicate Messages
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered by @peloy, the PLM Parser was silently dropping duplicate messages sequentially received in the same pass.
This adds a debug3 message to the log when such messages are dropped.
Partial fix for #186