Insteon: Fix Bug in Link Scan Callback When Nack Received #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearing $current_scan_device was resulting in an undefined object. This would happen when a device's aldb was listed as out-of-sync. In that scenario, query_aldb_delta would be called, but it would immediately call the aldb_changed_callback without exiting the loop. The callback would then set the current_scan_device and call scan_link_table on that device. At this point, a _send_msg would be queued and the loop would begin to exit. As it exited it would fall all the way back to line 117 of Insteon.pm and clear the current_scan_device. This patch prevents that error, by not relying on the state of an otherwise global variable in the logic tree.
krkeegan
added a commit
that referenced
this pull request
May 22, 2013
Insteon: Fix Bug in Link Scan Callback When Nack Received
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing $current_scan_device was resulting in an undefined object. This would happen when a device's aldb was listed as out-of-sync. In that scenario, query_aldb_delta would be called, but it would immediately call the aldb_changed_callback without exiting the loop.
The callback would then set the current_scan_device and call scan_link_table on that device. At this point, a _send_msg would be queued and the loop would begin to exit. As it exited it would fall all the way back to line 117 of Insteon.pm and clear the current_scan_device.
This patch prevents that error, by not relying on the state of an otherwise global variable in the logic tree.