Insteon: Add Link_to_Interface for I2CS Devices #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Success_callback is eval'd when the ACK for the message is received. - Note: There are so many callbacks all over the place within the code, it might be nice to condense as many as possible into this routine.
The routine requires a few steps to complete
Each routine needs to have success and failure callback parameters
The routine first checks to see if the device will respond to a get_engine_version request. If any ACK is received the routine continues as normal. In this case even if the device is an I2CS, the device must already have link entries as it responds to the PLM. If a NAK is received, it is assumes that this device is an i2cs and the link_to_interface_i2cs routine is called.
…ng-Complete Rather than clear the linking mode command when the device ACKs, wait to clear the message until the PLM reports the linking success.
This allows for per device _process_message subs to exist without needing to reproduce all of the eval code.
If flag not cleared, all messages to that device will stall
|
I made a few recent additions that make this much more stable. Buy waiting for the PLM to confirm that a link was made, we are less likely to get messages bumping into each other. |
krkeegan
added a commit
that referenced
this pull request
Oct 12, 2013
Insteon: Add Link_to_Interface for I2CS Devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we have all wanted for a while. It enables MH to create the initial link even on an I2CS device. To use it you just need to call the normal link_to_interface voice command.
The link_to_interface process is slightly slower now as it calls get_enging_version first.
The I2CS routine does:
The routine generally works, but because it requires so many steps it is more prone to failure than other routines, but there does not appear to be any harm in calling it multiple times if you are having issues.