Insteon: Add Is Deaf Routine for Battery Devices #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Delete Orphans Logic, had that backwards.
Reminder to self: don't use find and replace
| devices are not deaf, currently devices that are deaf are battery operated | ||
| devices such as the Motion Sensor, RemoteLinc and TriggerLinc. | ||
|
|
||
| At the BaseObject level all devices are defined as deaf. Objects which inherit |
There was a problem hiding this comment.
I think you mean that the devices are defined as NOT deaf, since line 1263 sets it to 0.
There was a problem hiding this comment.
Yup, sure did. More evidence of why I shouldn't write things late at night.
|
Just tested this code and it worked great for both my RemoteLinc and TriggerLinc. I do not have a MotionLinc to test with but should not be any different than the other "deaf" device types. |
Fix typo in description of base device's is_deaf default.
krkeegan
added a commit
that referenced
this pull request
Oct 18, 2013
Insteon: Add Is Deaf Routine for Battery Devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #279