Insteon: Prevent Calling Success Callback if No Active Message

[krkeegan]

No description provided.

[peloy]

I just ran into this issue after doing a manual link of a water leak sensor to my PLM:

01/12/14 09:43:10 PM [Insteon_PLM] DEBUG2: ALL-Linking Completed with 25b2a0 (000225b2a0000000)
Can't call method "success_callback" on an undefined value at /opt/misterhouse/bin/../lib/Insteon_PLM.pm line 778.
at /opt/misterhouse/bin/mh line 31
main::ANON('Can't call method "success_callback" on an undefined value a...') called at /opt/misterhouse/bin/../lib/Insteon_PLM.pm line 778
Insteon_PLM::parse_data('Insteon_PLM=HASH(0xae74f94)', '0253000225b2a0000000') called at /opt/misterhouse/bin/../lib/Insteon_PLM.pm line 210
Insteon_PLM::check_for_data('Insteon_PLM=HASH(0xae74f94)') called at /opt/misterhouse/bin/../lib/Insteon/BaseInterface.pm line 33
Insteon::BaseInterface::check_for_data() called at /opt/misterhouse/bin/mh line 1409
main::run_hooks('MainLoop_pre') called at (eval 342) line 5
main::MainLoop_pre_hooks() called at /opt/misterhouse/bin/mh line 1522
main::check_for_action called at /opt/misterhouse/bin/mh line 3303
main::monitor_commands called at /opt/misterhouse/bin/mh line 6724

I guess this is because there's still one place that the fix for issue #324 missed, per pmatis comment above.

Is a new issue or commit necessary to take care of this missing spot?

[krkeegan]

I merged a commit that ought to solve this.

On Sun, Jan 12, 2014 at 6:55 PM, Eloy Paris notifications@github.comwrote:

I just ran into this issue after doing a manual link of a water leak
sensor to my PLM:

01/12/14 09:43:10 PM [Insteon_PLM] DEBUG2: ALL-Linking Completed with
25b2a0 (000225b2a0000000)
Can't call method "success_callback" on an undefined value at
/opt/misterhouse/bin/../lib/Insteon_PLM.pm line 778.
at /opt/misterhouse/bin/mh line 31
main::ANON('Can't call method "success_callback" on an undefined value
a...') called at /opt/misterhouse/bin/../lib/Insteon_PLM.pm line 778
Insteon_PLM::parse_data('Insteon_PLM=HASH(0xae74f94)',
'0253000225b2a0000000') called at
/opt/misterhouse/bin/../lib/Insteon_PLM.pm line 210
Insteon_PLM::check_for_data('Insteon_PLM=HASH(0xae74f94)') called at
/opt/misterhouse/bin/../lib/Insteon/BaseInterface.pm line 33
Insteon::BaseInterface::check_for_data() called at /opt/misterhouse/bin/mh
line 1409
main::run_hooks('MainLoop_pre') called at (eval 342) line 5
main::MainLoop_pre_hooks() called at /opt/misterhouse/bin/mh line 1522
main::check_for_action called at /opt/misterhouse/bin/mh line 3303
main::monitor_commands called at /opt/misterhouse/bin/mh line 6724

I guess this is because there's still one place that the fix for issue
#324 #324 missed, per pmatis
comment above.

Is a new issue or commit necessary to take care of this missing spot?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/324#issuecomment-32142739
.

[peloy]

Thank you! Running git pull now...

Cheers!

Eloy Paris.-

On 01/19/2014 02:48 PM, Kevin Robert Keegan wrote:

I merged a commit that ought to solve this.

On Sun, Jan 12, 2014 at 6:55 PM, Eloy Paris
notifications@github.comwrote:

I just ran into this issue after doing a manual link of a water leak
sensor to my PLM:

01/12/14 09:43:10 PM [Insteon_PLM] DEBUG2: ALL-Linking Completed with
25b2a0 (000225b2a0000000)
Can't call method "success_callback" on an undefined value at
/opt/misterhouse/bin/../lib/Insteon_PLM.pm line 778.
at /opt/misterhouse/bin/mh line 31
main::ANON('Can't call method "success_callback" on an undefined
value
a...') called at /opt/misterhouse/bin/../lib/Insteon_PLM.pm line 778
Insteon_PLM::parse_data('Insteon_PLM=HASH(0xae74f94)',
'0253000225b2a0000000') called at
/opt/misterhouse/bin/../lib/Insteon_PLM.pm line 210
Insteon_PLM::check_for_data('Insteon_PLM=HASH(0xae74f94)') called at
/opt/misterhouse/bin/../lib/Insteon/BaseInterface.pm line 33
Insteon::BaseInterface::check_for_data() called at
/opt/misterhouse/bin/mh
line 1409
main::run_hooks('MainLoop_pre') called at (eval 342) line 5
main::MainLoop_pre_hooks() called at /opt/misterhouse/bin/mh line 1522
main::check_for_action called at /opt/misterhouse/bin/mh line 3303
main::monitor_commands called at /opt/misterhouse/bin/mh line 6724

I guess this is because there's still one place that the fix for issue
#324 #324 missed, per pmatis
comment above.

Is a new issue or commit necessary to take care of this missing spot?

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/324#issuecomment-32142739

.

—
Reply to this email directly or view it on GitHub
#324 (comment).