Fix data3 for responder records to PLM scene #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Issue #327. This fix also applies when a responder is I2CS and the controller is I1. Added logging for the data3 value. Aligned the logging levels between sync_links() and update_link().
|
Ahh yes, I did mix that up. Thank you Michael for catching my error. |
|
Ah no problem. This issue was easy to overlook in testing if you have a number of I2CS devices. Thanks for all the work on the sync_links and delete_orphan_links routines. They are significantly easier to follow. |
Add link_data3() function at the device level Modify aldb functions that set or check data3 to use the new function Add grotesque, level 5 logging that should be removed later
mstovenour
added a commit
that referenced
this pull request
Dec 19, 2013
Move aldb link data3 logic into Insteon objects Fix data3 for responder records to PLM scene Add flexibility to how aldb link data3 values are specified; each Insteon device can specify a unique behavior Update so that most Insteon objects use group 00 for endpoint 1 responder links (was 01 for all I2CS devices) Override logic for Insteon::SwitchLincRelay to use group 01 for endpoint 1 responder links for I2CS devices Note: Might consider doing the same for data1 and data2 in a future update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #327. This fix also applies when a responder is I2CS and the controller
is I1. Added logging for the data3 value. Aligned the logging levels between
sync_links() and update_link().