Pulled Weather{Warning} out of weather_chance_of_rain.pl, and created we... #357
Conversation
… weather_warnings.pl with more features such as announcements and a configurable trigger. Also added the ability to handle multi-line warning messages.
|
This looks like a valid change to me, but I'm not using this service as I don't live in the US. Anybody who wants to test this further or do we merge this pull request into master as is for the next stable release? |
|
Hi Lieven, I don't use the weather service, however the change seems to leave a if ($line =~/^warning:(.*)/i) { to next if ($line =~/^warning:/i); George
|
|
Hey George, Agreed, the extra capture is not required anymore. |
…ove Unnecessary Print Log - Made the regex change proposed by @gac410 re: one line warning regex in chance of rain - Remove extra 'Return' reference in chance of rain. This was causing the chance of rain loopcode to exit prematurely. In my case the was preventing the creating of the "read chance of rain" trigger. - Removed print log entry of 'WEATHER WARNING' It isnt't necessary as the read command will cause a print log entry if necessary
|
I tested this out, it appears to work as requested, although I have no weather warnings at the moment to be sure. I did catch a rather large bug in weather_chance_of_rain. It was issuing a return command outside of any subroutine, and was therefore causing the loopcode to return prematurely. I made a pull request to the @pmatis repository. Once Steve does his merge, we can merge this one. |
Weather: Fix Regex Check for Warnings; Fix Bug in Chance of Rain, Remove Unnecessary Print Log
Pulled Weather{Warning} out of weather_chance_of_rain.pl, and created we...
Pulled Weather{Warning} out of weather_chance_of_rain.pl, and created weather_warnings.pl with more features such as announcements and a configurable trigger. Also added the ability to handle multi-line warning messages.