Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug to note I2CS devices as potential sources of error #39

Merged
merged 1 commit into from
Jan 19, 2013

Conversation

krkeegan
Copy link
Collaborator

An I2CS device will respond with a NACK if you try and control it with the PLM
before it is linked as a responder. Add a note to the debug log regarding this.

An I2CS device will respond with a NACK if you try and control it with the PLM
before it is linked as a responder.  Add a note to the debug log regarding this.
@krkeegan
Copy link
Collaborator Author

Fixed the first request.

@marcmerlin
Copy link
Collaborator

This comment should likely say "a new I2CS type device that needs to be synced manually with the PLM first using the button"
I'll take this since it's an improvement, but I think the full message is more useful if you don't mind sending a followup

marcmerlin added a commit that referenced this pull request Jan 19, 2013
Update debug to note I2CS devices as potential sources of error
@marcmerlin marcmerlin merged commit 932f1a2 into hollie:master Jan 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants