Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_first_empty_address should return 0 if no addr #40

Merged
merged 1 commit into from
Jan 19, 2013
Merged

get_first_empty_address should return 0 if no addr #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/Insteon/AllLinkDatabase.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,9 +1219,9 @@ sub add_duplicate_link_address
sub delete_duplicate_link_address
{
my ($self, $address) = @_;
my $num_duplicate_link_addresses = 0;

$num_duplicate_link_addresses = @{$$self{aldb}{duplicates}} if (defined $$self{aldb}{duplicates});
my $num_duplicate_link_addresses = 0;
$num_duplicate_link_addresses = @{$$self{aldb}{duplicates}} if (defined $$self{aldb}{duplicates});
if ($num_duplicate_link_addresses)
{
my @temp_duplicates = ();
Expand All @@ -1241,8 +1241,8 @@ sub add_empty_address
{
my ($self, $address) = @_;
# before adding it, make sure that it isn't already in the list!!
my $num_addresses = 0;
$num_addresses = @{$$self{aldb}{empty}} if (defined $$self{aldb}{empty});
my $num_addresses = 0;
$num_addresses = @{$$self{aldb}{empty}} if (defined $$self{aldb}{empty});
my $exists = 0;
if ($num_addresses and $address)
{
Expand Down Expand Up @@ -1298,7 +1298,7 @@ sub get_first_empty_address
$low_address = $new_address if $new_address < $low_address;
}
}
$first_address = sprintf('%04X', $low_address - 8);
$first_address = ($low_address > 0) ? sprintf('%04X', $low_address - 8) : 0;
}

return $first_address;
Expand Down