Fix #406 deprecated code

[hollie]

Fixes the deprecated warnings according to issue #406.

Note: I only fixed the code under 'lib' and not in '/lib/site/' as those modules are CPAN modules. Can't we just get recent versions from those from CPAN when deploying MisterHouse instead of keeping track of those in our own codebase?

[JaredF]

if ($$self{hop_array} && !(@{$$self{hop_array}})) {

works for me. Please confirm that the test performs the same function as the original line.

[hollie]

Hey @JaredF I have added your patch to the pull request. Thanks. According to me this code still performs what the original author intended.

[krkeegan]

Not quite right. The logic here should be if hop_array does not exist do something. The proposed code would skip the something if the array does not exist and the hash value has not been declared.

The line should just be if (!(@{$$self{hop_array}})) {

[krkeegan]

Oops, no that won't work with strict enabled. But this does if (!$$self{hop_array} || !(@{$$self{hop_array}})) {

So now if the hash key is undefined OR the value is not an array then we do something. That should do it.

See #411 for my pull request.

[JaredF]

Okay, this makes sense. Didn't realize that it was strict that was throwing the error. @hollie's original pull was if (!(@{$$self{hop_array}})) { but we had changed it since it was throwing the error from strict.

[peloy]

Hi Kevin,

On Thu, May 15, 2014 at 10:10:01AM -0700, Kevin Robert Keegan wrote:

@@ -275,7 +275,7 @@ sub default_hop_count
if (defined($hop_count)){
::print_log("[Insteon::BaseObject] DEBUG3: Adding hop count of " . $hop_count . " to hop_array of "
. $self->get_object_name) if $self->debuglevel(3, 'insteon');

•   if (!defined(@{$$self{hop_array}})) {
  

•   if ($$self{hop_array} && !(@{$$self{hop_array}})) {
  

Oops, no that won't work with strict enabled. But this does if (!$$self{hop_array} || !(@{$$self{hop_array}})) {

So now if the hash key is undefined OR the value is not an array then we do something. That should do it.

I have no idea what the above test is meant to accomplish but I have a
few comments, just in case they help to find issues with the new code:

• The original test apparently wanted to check if $self->{hop_array} (an
  array reference) existed.
• I think the new test before Kevin's comment checks that
  $self->{hop_array} is not undef, and that the size of the array is zero
  (using an array in scalar context produces the length of the array). Is
  this not correct?
• Kevin's proposed change actually changes the logic result of the test.
  Perhaps the original test as proposed was incorrect and Kevin's proposed
  change fixes it, I don't know. But I do now that A AND B = (NOT A) OR
  (NOT B) so if the original test is:

$$self{hop_array} && !(@{$$self{hop_array}})

it can be re-written as follows without changing the logic result:

!$$self{hop_array} || (@{$$self{hop_array}})

But Kevin's proposed change leaves the NOT ('!') in the operand after
the logical OR. Is that intended?

Cheers,

Eloy Paris.-

[hollie]

Hey @JaredF,

can you please run a final test on this branch so that we can merge it into master if it works fine for you?

Thanks!
Lieven.

[JaredF]

No problem; will test it tonight.

[JaredF]

Just tested it and everything looks good. No more deprecated code warnings and MH starts up successfully.