AD2: Add Better Support for Monitoring Bypassed Zones #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, we would accidentally send commands directly to the alarm by accident.
Certain zone states, such as Bypass, can only be determined when they are set. As a result, we need to cache and save the zone states through a reboot, otherwise we will change a zone from bypass->ready whenever we reboot. This does leave open the possibility of incorrectly setting a zone state if the zone changed state while MisterHouse was down.
Add a separate function for checking the bypassed state of a zone. Change status_zone function. It will only report a zone as bypassed if the zone is hardwired. All other zone types we can continue to track even when bypassed. Cleanup ChangeZoneState, it now only affects a single zone, the complicated looping for setting multiple zones is moved into the respective places in the code.
krkeegan
added a commit
that referenced
this pull request
Jun 27, 2014
AD2: Add Better Support for Monitoring Bypassed Zones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.