Insteon/X10: Skip Calling Set_Receive on PLM #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not clear on what this does for a general X10 interface, but the Insteon PLM has no state, therefore it has no set_receive command. The safest thing to do is just to skip this call for Insteon PLMs.
|
No comments from those who had issues, but I can't see how this would cause problems. |
krkeegan
added a commit
that referenced
this pull request
Jul 25, 2014
Insteon/X10: Skip Calling Set_Receive on PLM
|
Hi Kevin, I have not seen any further issues. Everything has been stable. But George On 07/25/2014 06:18 PM, Kevin Robert Keegan wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not clear on what this does for a general X10 interface, but the Insteon PLM has no state, therefore it has no set_receive command. The safest thing to do is just to skip this call for Insteon PLMs.
Fixes #434