Insteon: Some Fixes to Scan Link Tables and Link Table Nomeclature #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
krkeegan
commented
Sep 11, 2014
krkeegan
commented
- Fixes Insteon: Improve Scan all Changed Link Tables to Skip PLM if Unchanged #402 - The status of the PLM link table is monitored and the PLM will only be scanned when calling 'scan changed link tables' if it has actually changed.
- The nomenclature for referring to the link table health now uses (changed/unchanged) instead of the old (out-of-sync/good). The out of sync reference confused some users because of its similarity to "sync links".
- Renamed the PLM voice commands for clarity.
This way, the record is added to the PLM cache no matter how the record was added to the PLM. This includes manual linking.
…ync; Handle both responder and controller links. Handle manually delete links. Mark out of sync if manually reset.
While not specifically enabled in the code, it may one day be, or an advanced user may somehow trigger it.
It was confusing to list both links and link tables as "out-of-sync." At least for link tables, the likely command would be "sync ...." but in fact it is "scan ...". Now, link tables can be unknown|empty|changed|unchanged. This fits with the prior voice command "scan changed link tables." Hopefully this will lead to less confusion.
Added a prefix to distinguish PLM/Global voice commands. Changed the name of 'scan all device link tables' to 'force scan...' to try and underscore that it is not a routine function
… Command Reference
|
@krkeegan I see it's been sitting here for a while. We trust you to self merge your insteon code since you know better than us :) |
|
I ran a quick test of this one and didn't encounter any issues. Any objections to merging this? |
|
No objection from me! |
JaredF
added a commit
that referenced
this pull request
Jul 27, 2015
Insteon: Some Fixes to Scan Link Tables and Link Table Nomeclature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.